Fossil

Timeline
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

50 most recent check-ins by user george

2022-05-18
22:52
Fix a couple of invokations of <code>backlink_extract()</code> that were overlooked in the previous check-in. ... (Leaf check-in: 33c67c2851 user: george tags: generated-tkt-mimetype)
20:21
Add support for generated "mimetype" column in the <var>TICKET</var> table. Introduce integer mimetype codes and refactor <code>backlink_extract()</code> accordingly. Make the overall handling of the generated "mimetype" columns a bit more clear. ... (check-in: e39f77906e user: george tags: generated-tkt-mimetype)
2022-05-14
20:52
Handle a possible existence of the additional checkbox introduced in [29a24941ed9bf4]. ... (Leaf check-in: 76844c35fc user: george tags: wcontent-subsets)
19:12
A tiny optimization inside of <tt>ticket_insert()</tt>: rearrange two <tt>db_finalize()</tt> calls in order to avoid additional <tt>malloc()</tt> for <var>zMimetype</var>. ... (check-in: 563c6b9e4e user: george tags: generated-tkt-mimetype)
18:27
If "<var>mimetype</var>" column of the <var>TICKETCHNG</var> table is a [https://www.sqlite.org/gencol.html|generated column], than use these generated values for extraction of backlinks from the ticket-changes. ... (check-in: 5ab73ab8c7 user: george tags: generated-tkt-mimetype)
17:42
Fix a subtle bug in <code>ticket_insert()</code> which may lead to redundant rows in the BACKLINK table. The bug appeared in [7c13a57358ae]. ... (check-in: 3b42738e36 user: george tags: generated-tkt-mimetype)
2022-05-13
23:35
If <var>TICKETCHNG</var> table has <var>TKT_USER</var> column then make the values in that column match to the corresponding [/doc/tkt-ucard/www/fileformat.wiki#tktchng|U-cards]. Add <var>TKT_USER</var> to the default schema. See [forum:/forumthread/5593538afb7746bf|forum thread 5593538afb77] for rationale. ... (check-in: cf00d07c34 user: george tags: trunk)
2022-05-11
21:23
Ensure that <var>$requested_page</var> is always initialized. This is a follow-up to [c68fa2edd76d90] that fixes a bug in [b05a6c6bc826d3]. ... (check-in: a44e3c7338 user: george tags: trunk)
2022-05-09
21:22
Supply TH1 interpreter with two auxiliary variables: <var>$requested_page</var> (holds the first segment of the requested [/file/src/cgi.c?ln=1199-1209&ci=2022-05-09|PATH_INFO]) and <var>$canonical_page</var> (holds the canonical name of a web-page being served). Also amend default HTML header: add two corresponding classes to the BODY element and move <code><meta charset="UTF-8"></code> to the top. ... (check-in: b05a6c6bc8 user: george tags: trunk)
2022-05-08
20:40
Rename proposed column to <var>tkt_user</var> which seems more natural. Amend default schema to create this column (and also drop a nearby comment). Add a tiny optimization to <code>getAllTicketFields()</code>. ... (Closed-Leaf check-in: 6d95ae4f88 user: george tags: tkt-ucard)
2022-05-01
21:00
Add support for optional <var>tkt_ucard</var> column of the <var>TICKETCHNG</var> table. If this column is present then its value is populated from the [/doc/tkt-ucard/www/fileformat.wiki#tktchng|U-card] of the corresponding artifact. ... (check-in: d681e1dc1d user: george tags: tkt-ucard)
20:53
Minor code clean-up inside of <tt>ticket_insert()</tt> function. ... (check-in: 3e4ba24e29 user: george tags: tkt-ucard)
2022-04-23
21:32
Extend [/md_rules#ftnts|Markdown] with footnotes support. See [/wiki?name=branch/markdown-footnotes#il|known limitations] and the corresponding [forum:/forumthread/ee1f1597e46ec07a|forum thread]. ... (check-in: 3990518b29 user: george tags: trunk)
17:23
Change signature of <code>add_inline_footnote()</code> in order to move away from returning of unreliable pointer. Amend a few comments. Fix a couple of minor issues that fuzzer complains about. ... (Closed-Leaf check-in: 0850862e6a user: george tags: markdown-footnotes)
15:56
Fix a possible heap-buffer-overflow in <code>parse_htmlblock()</code> introduced by [1e919d601f774fdb]. This is not related to footnotes but was revealed by fuzzing (case 80cbb6b185807e98a953426af7b1f802c9d13957). ... (check-in: bc4c5b6311 user: george tags: markdown-footnotes)
2022-04-22
12:49
Remove redundant <code>assert()</code> that fails for the case when the content of a span-bounded inline footnote is rendered into a void. This is a corner case that was revealed via fuzzing. ... (check-in: cab8a586ae user: george tags: markdown-footnotes)
2022-04-21
22:31
Add a test case for fragment-bounded footnote that contains markup within the corresponding text fragment. ... (check-in: d38ec43d00 user: george tags: markdown-footnotes)
21:13
Fix another use-after-realloc bug in handling of inline footnotes which was discovered during fuzzing. Also fix a few other issues revealed via fuzzer. ... (check-in: c5456211f4 user: george tags: markdown-footnotes)
13:36
Revert Makefile.in to normal builds (leave a few comments about fuzzing). ... (check-in: 940779668f user: george tags: markdown-footnotes)
13:16
Fix a use-after-free bug in handling of nested inline footnotes. The bug was discovered by fuzzing with <code>'-fsanitize=fuzzer,undefined,address -DFOSSIL_FUZZ'</code> appended to <var>TCCFLAGS</var> in Makefile.in. It's noteworthy that the <code>',undefined,address'</code> part was essential to find the bug (otherwise just 'double-free' was reported). Many thanks to Stephan for documenting the fuzzing procedures and support. ... (check-in: 31e5df5fa2 user: george tags: markdown-footnotes)
2022-04-19
15:25
Remove unnecessary field from the auxiliary union <code>'bitfield64_t'</code> and amend the corresponding comments. Also add comment about FOOTNOTES_WITHOUT_URI macro. ... (check-in: cf1e96918e user: george tags: markdown-footnotes)
2022-02-23
12:33
Count overnesting as the fourth type of the footnote-related issues and report accordingly. ... (check-in: ae297bb671 user: george tags: markdown-footnotes)
09:45
Minor refactoring. Move the definition of <code>BLOB_APPEND_LITERAL()</code> macro from <code>markdown_html.c</code> to <code>blob.c</code> so that it could be used outside of <code>markdown_html.c</code>. Also rename it to lowercase for consistency with other API. Within <code>markdown.c</code> use that newly available macro instead of <code>blob_append_string()</code>. Within <code>markdown_html.c</code> use it for footnotes-relevant code. Other invocations of <code>BLOB_APPEND_LITERAL()</code> within <code>markdown_html.c</code> are left intact (they use an alias) in order to simplify the potential merge with the trunk. ... (check-in: c8a8d0c94c user: george tags: markdown-footnotes)
08:21
Minor refactoring. Move the definition of <code>BLOB_APPEND_BLOB()</code> macro from <code>markdown_html.c</code> to <code>blob.c</code> so that it could be used outside of <code>markdown_html.c</code>. Also rename it to <code>blob_appendb()</code> for consistency with <code>blob_appendf()</code> and other API. Within <code>markdown.c</code> use that newly available macro where appropriate. Within <code>markdown_html.c</code> use it for footnotes-relevant code. Other invocations of <code>BLOB_APPEND_BLOB()</code> within <code>markdown_html.c</code> are left intact (they use an alias) in order to simplify the potential merge with the trunk. ... (check-in: 33a681ebee user: george tags: markdown-footnotes)
07:36
Fix handling of user-provided classes for unreferenced, joined and overnested footnotes. In all these cases the tokens of user-provided classes are rendered as plain-text and no special classes are added anywhere. ... (check-in: 875472a8b0 user: george tags: markdown-footnotes)
2022-02-21
05:14
Add a comment for <code>append_footnote_upc()</code>. Also substitute a variable of zero value with just "0" constant. No functional changes. ... (check-in: ae8a3dd5aa user: george tags: markdown-footnotes)
04:29
Impose a limit on the depth of nesting of inline footnotes. Also add a few test cases: for depth limiting and HTML hijacking. ... (check-in: f4ff013ace user: george tags: markdown-footnotes)
2022-02-20
23:00
If there are issues with footnotes then set TH1 variable <var>$footnotes_issues_counters</var> to a space separated list of integers that count for "misref", "unref" and "joins". This eliminates the need for JavaScript for the case when a custom skin wants to [forum:/forumpost/119b0be29a2b096b|warn about issues with footnotes] in the header of a page.<br> Also fix counting of "joins": count the number of unique labels that have multiple definitions (and not the number of such definitions). ... (check-in: 773cef5cf7 user: george tags: markdown-footnotes)
2022-02-19
01:59
Fix hyperlinks on the [/help?cmd=/winfo|/winfo] page. These were broken when a page was accessed through [/help?cmd=/info|/info/HASH] or <code>/winfo/HASH</code> aliases. ... (check-in: 356a4845b3 user: george tags: trunk)
01:16
Parse inline footnotes even if a renderer does not define a callback for rendering of footnote markers. This seems more correct even though the current implementation of backlink processor does define such callback as an empty function. ... (check-in: e06c12d176 user: george tags: markdown-footnotes)
01:00
Handle some corner cases more thoroughly: dismiss empty footnotes, passthrough (more carefully) user-provided classlist if the token is not followed by a blank character or if a footnote's text consists just of such token and blank characters. Also simplify a little bit a few places inside of <code>is_footnote()</code> function. ... (check-in: fe3157803f user: george tags: markdown-footnotes)
2022-02-18
01:33
Add <code>--lint-footnotes</code> option to the <code>test-markdown-render</code> command. If this flag is given and footnotes in the input have issues, then print to <var>stderr</var> the counters of "misrefs", "strays" and "split-defs" and exit with error. This should partially address a concern [forum:/forumpost/119b0be29a2b096b|raised at the forum]. ... (check-in: 1f525713ff user: george tags: markdown-footnotes)
2022-02-17
22:09
If a footnote's text starts with a token of the special form then use this token to derive a set of CSS classes that are added to that footnote and its references. This enables users to style elements of a particular footnote provided that the administrator provisioned and documented some special CSS classes in a custum skin. Default skin does not provide any of such special classes which makes this feature an "opt-in". ... (check-in: 92516ced8b user: george tags: markdown-footnotes)
00:17
Clean-up and rephrase some comments. ... (check-in: a62c876896 user: george tags: markdown-footnotes)
2022-02-16
23:08
Make parsing slightly faster and fix a comment. No changes in functionality. ... (check-in: a36dd09d17 user: george tags: markdown-footnotes)
22:11
Include <code>REQUEST_URI</code> into footnotes' hyperlinks. This should make links work even if base href (in a page's header) is not consistent with the <code>REQUEST_URI</code>. If <code>FOOTNOTES_WITHOUT_URI</code> macro is defined while compiling <code>src/markdown_html.c</code> then bare "#fragment" hyperlinks (without <code>REQUEST_URI</code>) are generated. ... (check-in: 2c1f8f3592 user: george tags: markdown-footnotes)
2022-02-15
21:35
FIXME-comments in the code did not indicate issues and are now rephrased to be mere reminders. ... (Leaf check-in: d253ece08a user: george tags: base-href-fix)
02:26
Do not override base href for wiki pages. This needs testing. ... (check-in: 89dd34519f user: george tags: base-href-fix)
00:58
When setting <var>$webpagename</var> pass the value of <var>g.zPath</var> though <code>escape_quotes()</code>. This is unclear how <var>g.zPath</var> can contain quotes but let this strange case be handled in a safe way. ... (check-in: 288fe34ced user: george tags: base-href-fix)
00:14
Move <code><meta charset="UTF-8"></code> to the begining of the default header. Supply BODY element with a class that derives from <var>$webpagename</var>. ... (check-in: 6d135904ad user: george tags: base-href-fix)
2022-02-14
23:32
Minor code refactoring: rename a temporary variable and utilize <code>matching_bracket_offset()</code> one more time. No changes in functionality. ... (check-in: 5b845a0790 user: george tags: markdown-footnotes)
23:06
Do not export <var>g.zRelReqURI</var> to TH1 interpreter because <code>getParameter</code> proc can retrieve <code>PATH_INFO</code> and <code>QUERY_STRING</code>. Instead export <var>g.zPath</var> (as <var>$webpagename</var>) since that is typically needed in the TH1 headers/footers of custom skins. ... (check-in: ff4c7ed609 user: george tags: base-href-fix)
22:43
Make <code>style_set_base_href_suffix()</code> safe for misuse: if the resulting suffix contains unescaped quotes then escape them. <var>$base_href_suffix</var> is intended for interpolation inside of the quoted href attribute. This check-in should address the case when a user of malfunctioning browser (which mishandles quoting) is tricked by an adversary to visit a specially crafted hyperlink. ... (check-in: d97752f30b user: george tags: base-href-fix)
2022-02-13
19:29
Fix parsing of "free-standing" footnotes that was (slightly) broken by the previous check-in. ... (check-in: 23c3e0b2a7 user: george tags: markdown-footnotes)
17:54
Rename variable <var>g.zUrlSuffix</var> to <var>g.zRelReqURI</var> (Relative Request URI). Provide it to TH1 interpreter as <var>$relrequri</var>. ... (check-in: 05e3fa76be user: george tags: base-href-fix)
16:00
Fix hyperlinks on the [/help?cmd=/winfo|/winfo] page. These were broken when a page was rendered through [/help?cmd=/info|/info/HASH] of <code>/winfo/HASH</code> aliases. ... (check-in: 5ce372ce48 user: george tags: base-href-fix)
01:35
Cherry-pick from branch 'cgi-compliance' (and thus back out [5bb921dd0893a548]). Adapt the computation of g.zUrlSuffix in <code>set_base_url()</code> accordingly. ... (check-in: 5c649c7e0f user: george tags: base-href-fix)
2022-02-12
21:51
Add an overlooked call to <code>style_set_base_href_suffix()</code> in src/info.c and add a comment of why not to do so for [/help?cmd=/ext|/ext] ... (check-in: 87fba73120 user: george tags: base-href-fix)
20:52
If markup is ambigous between a "span-bounded" footnote and a "free-standing" footnote followed by another footnote then interpret as the later case. ... (check-in: b363a4dbe7 user: george tags: markdown-footnotes)
19:53
An attepmt to fix the [https://developer.mozilla.org/en-US/docs/Web/HTML/Element/base|<code><base href="..."></code>] element of webpages so that the value of <var>href</var> attribute matches the URL being served. This should fix "#fragment" hyperlinks on all pages where these were broken (all except [/help?cmd=/doc|<code>/doc</code>]). The values for [/help?cmd=/wiki|<code>/wiki</code>] and [/help?cmd=/info|<code>/info</code>] were left unchanged (it's yet unclear if they should also be changed). ... (check-in: 03b39f1d00 user: george tags: base-href-fix)